Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logit scaling sdpa using FlexAttention for Gemma2 #32877

Closed
3 tasks
ArthurZucker opened this issue Aug 19, 2024 · 1 comment · Fixed by #34282
Closed
3 tasks

Add logit scaling sdpa using FlexAttention for Gemma2 #32877

ArthurZucker opened this issue Aug 19, 2024 · 1 comment · Fixed by #34282
Labels
Feature request Request for a new feature Good Difficult Issue

Comments

@ArthurZucker
Copy link
Collaborator

ArthurZucker commented Aug 19, 2024 •
edited
Loading

Feature request

With the recent publish of FlexAttention, think it makes senses to support it with sdpa path of Gemma2.
Leaving it open to the community:

  • implement the path
  • make sure integration tests work
  • add some doc

Related to #32865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature request Request for a new feature Good Difficult Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gemma capping huggingface/transformers
2 participants
@drisspg @ArthurZucker