Deprecation Warning for max_size in DetrImageProcessor.preprocess

[HichTala]

System Info

• transformers version: 4.47.0.dev0
• Platform: Linux-5.15.0-126-generic-x86_64-with-glibc2.31
• Python version: 3.11.0
• Huggingface_hub version: 0.24.5
• Safetensors version: 0.4.4
• Accelerate version: 1.1.1
• Accelerate config: not found
• PyTorch version (GPU?): 2.1.2+cu118 (True)
• Tensorflow version (GPU?): not installed (NA)
• Flax version (CPU?/GPU?/TPU?): not installed (NA)
• Jax version: not installed
• JaxLib version: not installed
• Using distributed or parallel set-up in script?:
• Using GPU in script?:
• GPU type: NVIDIA GeForce RTX 3090

Who can help?

@amyeroberts, @qubvel
and I think @NielsRogge worked on it too ?

Information

• The official example scripts
• My own modified scripts

Tasks

• An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
• My own task or dataset (give details below)

Reproduction

import logging

import numpy as np
from transformers.models.detr.image_processing_detr import DetrImageProcessor

logging.basicConfig(level=logging.WARNING)
logger = logging.getLogger(__name__)

images = [np.ones((512, 512, 3))]
annotations = [{'image_id': [], 'annotations': []}]
size = {'max_height': 600, 'max_width': 600}

image_processor = DetrImageProcessor()
images = image_processor.preprocess(images, do_resize=True, do_rescale=False, size=size, annotations=annotations, format='coco_detection')

Expected behavior

Hello!

I noticed that the preprocess method in the DetrImageProcessor class always passes max_size to the resize method,

transformers/src/transformers/models/detr/image_processing_detr.py

Lines 1445 to 1447 in 4120cb2

	resized_image = self.resize(
	image, size=size, max_size=max_size, resample=resample, input_data_format=input_data_format
	)

and that triggers a deprecation warning in resize method,

The `max_size` parameter is deprecated and will be removed in v4.26. Please specify in `size['longest_edge'] instead`.

transformers/src/transformers/models/detr/image_processing_detr.py

Lines 992 to 997 in 4120cb2

	if "max_size" in kwargs:
	logger.warning_once(
	"The `max_size` parameter is deprecated and will be removed in v4.26. "
	"Please specify in `size['longest_edge'] instead`.",
	)
	max_size = kwargs.pop("max_size")

I propose removing the unused max_size argument from the preprocess method since it is always None,

transformers/src/transformers/models/detr/image_processing_detr.py

Line 1340 in 4120cb2

max_size = None

Would it be okay if I work on this and submit a pull request? I can try to see if the problem also occurs in other models.

[qubvel]

Hi @HichTala! Nice catch, would appreciate a PR!