Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/rag: test coverage, tiny model #7715

Open
sshleifer opened this issue Oct 11, 2020 · 6 comments
Open

examples/rag: test coverage, tiny model #7715

sshleifer opened this issue Oct 11, 2020 · 6 comments
Labels
Feature request Request for a new feature Help wanted Extra attention is needed, help appreciated rag Tests Related to tests

Comments

@sshleifer
Copy link
Contributor

sshleifer commented Oct 11, 2020

Disclaimer: I don't know this code very well, this may be much harder than it seems.
Blocking PR: #7713

[examples/rag/finetune.py, examples/rag/finetune.sh, eval_rag.py] do not seem to be tested at all.
It would be good to have a test_finetune.py like examples/seq2seq that tested these.

cc @stas00 if interested, rag is a cool new retrieval model https://arxiv.org/pdf/2005.11401.pdf

@sshleifer sshleifer added rag Tests Related to tests Help wanted Extra attention is needed, help appreciated labels Oct 11, 2020
@sshleifer sshleifer changed the title test coverage, tiny model for examples/rag examples/rag: test coverage, tiny model Oct 11, 2020
@stas00
Copy link
Contributor

stas00 commented Oct 11, 2020

sign me up, Sam

@shamanez
Copy link
Contributor

@sshleifer

examples/rag/finetune.py is not that stable. Seems like it depends on the pytorch_lightning version also. It would be nice if we can test it properly.

@stale stale bot added the wontfix label Jan 11, 2021
@stas00 stas00 added the Feature request Request for a new feature label Jan 11, 2021
@stale stale bot removed the wontfix label Jan 11, 2021
@huggingface huggingface deleted a comment from stale bot Jan 11, 2021
@stas00
Copy link
Contributor

stas00 commented Jan 11, 2021

I think this is still waiting for: #8284 to complete the missing info and perhaps some tests were added since then?

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This issue has been stale for 1 month.

@stas00 stas00 removed their assignment Mar 6, 2021
@stas00
Copy link
Contributor

stas00 commented Mar 6, 2021

As the required to implement this info was never provided and I since then moved to work on other things I removed self-assignment to this ticket...

@4imothy
Copy link
Contributor

4imothy commented Jan 13, 2024

Should this issue be closed looks like rag now has some tests here and here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Request for a new feature Help wanted Extra attention is needed, help appreciated rag Tests Related to tests
Projects
None yet
Development

No branches or pull requests

4 participants