Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLflowCallback to log run_name argument #8519

Closed
HenryMaguire opened this issue Nov 13, 2020 · 5 comments · Fixed by #14894
Closed

MLflowCallback to log run_name argument #8519

HenryMaguire opened this issue Nov 13, 2020 · 5 comments · Fixed by #14894
Assignees
Labels

Comments

@HenryMaguire
Copy link

🚀 Feature request

When using the MLflowCallback (set as default for Trainer), I would like to log the run_name argument passed to TrainingArguments as the Run Name on the MLflow dashboard. Currently runs are being logged as nameless.
E.g. see below.
Screenshot 2020-11-13 at 10 29 32

Motivation

Trainer makes training 🤗 models so easy and MLflow is great for organising experiments/caching artifacts. I would like to make it easier to organise experimental runs and make research easier, particularly for larger teams. This feature would be a very simple patch on the original PR #8016

example usage

training_args = TrainingArguments(
    label_names=['labels_t1', 'labels_t2'],
    output_dir='./runs,          # output directory
    run_name='multitask_clf_<run_name>',
)
trainer = Trainer(
    model=model,        # the instantiated 🤗 Transformers model to be trained
    args=training_args,        # training arguments, defined above
    train_dataset=train_dataset,        # training dataset
)

Your contribution

I can submit a PR

@sgugger
Copy link
Collaborator

sgugger commented Nov 13, 2020

Please don't hesitate to suggest a PR, run_name is there just for this reason!

@stale
Copy link

stale bot commented Jan 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 16, 2021
@stale stale bot closed this as completed Jan 24, 2021
@ksopyla
Copy link

ksopyla commented Jun 2, 2021

It will be useful to have this, and it will organize all the experiments better.

@yangdong02
Copy link
Contributor

Is there any update on this issue and #12841? I have a very simple one-line solution of passing args.run_name (which currently serves for wandb) to mlflow.start_run that can fix this. I can submit a PR in case of need.

@pratikchhapolika
Copy link

@HenryMaguire can you send link to your notebook or colab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants