Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"setup.py" does not seem to have been updated for v3.5.1 #8566

Closed
forest1988 opened this issue Nov 16, 2020 · 3 comments · Fixed by #8568
Closed

"setup.py" does not seem to have been updated for v3.5.1 #8566

forest1988 opened this issue Nov 16, 2020 · 3 comments · Fixed by #8568

Comments

@forest1988
Copy link
Contributor

Environment info

I try

!git clone https://github.com/huggingface/transformers.git
%cd transformers/
!pip install -e .

on Colaboratory.

  • transformers version: 3.5.0 <- this seems strange.
  • Platform: Linux-4.19.112+-x86_64-with-Ubuntu-18.04-bionic
  • Python version: 3.6.9
  • PyTorch version (GPU?): 1.7.0+cu101 (True)
  • Tensorflow version (GPU?): 2.3.0 (True)
  • Using GPU in script?:
  • Using distributed or parallel set-up in script?:

Who can help

documentation: @sgugger

Information

"setup.py" does not seem to have been updated for v3.5.1.

When I install transformers by pip install -e ., the version of transformers is shown as v3.5.0.

To reproduce

Steps to reproduce the behavior:

I try

!git clone https://github.com/huggingface/transformers.git
%cd transformers/
!pip install -e .

on Colaboratory after v3.5.1 release.

Then,

import transformers
transformers.__version__

returns

'3.5.0'

Expected behavior

The return of transformers.__version__ is expected to be '3.5.1' now, if my understanding is not wrong.

Maybe, in

version="3.5.0",

'3.5.0' should be changed to '3.5.1'.

Is my understanding correct? Sorry if I misunderstand your intension.

@forest1988
Copy link
Contributor Author

I found d5b3e56 and it seems the related files are updated there.
If there is a reason (or rules for releases) not to merge the change into the master branch, I'm sorry for opening this issue that I haven't fully considered.

@sgugger
Copy link
Collaborator

sgugger commented Nov 16, 2020

This was a hotfix on a branch which is why we didn't update master (mostly because we forgot).
To do things right, we'll actually put v4.0.0-dev since that's what master is right now :-)

@forest1988
Copy link
Contributor Author

@sgugger
Thank you for your quick and detailed response!
Now I understood what is the reason.
I appreciate your creating a new PR for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants