Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for syncing forked masters to avoid references #8742

Closed
bdalal opened this issue Nov 23, 2020 · 0 comments · Fixed by #8745
Closed

Add instructions for syncing forked masters to avoid references #8742

bdalal opened this issue Nov 23, 2020 · 0 comments · Fixed by #8745

Comments

@bdalal
Copy link
Contributor

bdalal commented Nov 23, 2020

🚀 Feature request

Motivation

Ticket created based on discussion lucidworks@46b17d2#commitcomment-44356945
The problem is when someone on a forked repository decides to sync up their masters with upstream (HF master) using a branch and a PR, all the PR and issue references on the upstream will make their way into the forked PR's commit history, if that user creates a merge commit.
Since GitHub autolinks issues and PRs on public forks, this will end up pinging the devs responsible for the referenced PRs creating unnecessary noise. The solution is to use a squashed merge.

One way to educate users with forked repos about this potential issue is to add instructions on how to do so to the CONTRIBUTING.md file.

Your contribution

A PR with instructions to avoid this situation will be up shortly.

cc @stas00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant