Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

05-gpt2-sentiment-control.ipynb notebook, gpt2_tokeinizer is missing #48

Closed
saeedashraf opened this issue Nov 9, 2022 · 2 comments
Closed

05-gpt2-sentiment-control.ipynb notebook, gpt2_tokeinizer is missing #48

saeedashraf opened this issue Nov 9, 2022 · 2 comments

Comments

@saeedashraf
Copy link

in 05-gpt2-sentiment-control.ipynb notebook:

ppo_trainer = PPOTrainer(gpt2_model, gpt2_model_ref, **config)

there is a tokenizer argument missing... should be

ppo_trainer = PPOTrainer(gpt2_model, gpt2_model_ref, gpt2_tokeinizer, **config)
@lvwerra
Copy link
Member

lvwerra commented Dec 7, 2022

Thanks, I'll fix that!

@lvwerra
Copy link
Member

lvwerra commented Jan 30, 2023

Should be fixed with #80.

@lvwerra lvwerra closed this as completed Jan 30, 2023
@August-murr August-murr mentioned this issue Jan 6, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lvwerra @saeedashraf