Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support wandb log in dpo #568

Closed
akk-123 opened this issue Jul 25, 2023 · 2 comments · Fixed by #570
Closed

support wandb log in dpo #568

akk-123 opened this issue Jul 25, 2023 · 2 comments · Fixed by #570

Comments

@akk-123
Copy link

akk-123 commented Jul 25, 2023

  1. dpo use self.log_metrics to log metric now, please support more friendly wandb log like PPOTrainer
  2. dpo need load 2 model, can you support lora model, so that only load one model
@kashif
Copy link
Collaborator

kashif commented Jul 25, 2023

regarding point 2 @akk-123, the reference model is used in evaluation mode and the main model can certainly be prepared for training via Peft and that should work as per the other trainers using peft

@akk-123
Copy link
Author

akk-123 commented Jul 26, 2023

@kashif thanks. I use lora to train main model, and set save_steps to save weight, I found that there saved too many things
image
how can I only save adapter_model.bin and adapter_config.json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants