Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'ignore' option is broken for hidden files & files inside hidden directories #51

Open
Lucas-C opened this issue Jun 23, 2016 · 5 comments · May be fixed by #58
Open

The 'ignore' option is broken for hidden files & files inside hidden directories #51

Lucas-C opened this issue Jun 23, 2016 · 5 comments · May be fixed by #58

Comments

@Lucas-C
Copy link

Lucas-C commented Jun 23, 2016

Due to this longstanding minimatch bug, the ignore option will never filter out files containing a directory starting with a dot anywhere in their path, nor files starting with a dot.

E.g. /home/bob/.jenkins/jobs/HellowWorld/workspace/snafu.js
@Lucas-C
Copy link
Author

Lucas-C commented Jun 23, 2016

Actually minimatch provides an option for this : could uglifyify use {dot: true} by default ?

@Lucas-C
Copy link
Author

Lucas-C commented Jul 27, 2016

Any update on this @hughsk ?

@kevincolten kevincolten linked a pull request Nov 9, 2016 that will close this issue
Open
@kevincolten
Copy link

@Lucas-C @hughsk take a look at my PR

@Lucas-C
Copy link
Author

Lucas-C commented Nov 14, 2016

Looks great ! Thanks.
Could you merge this PR @hughsk please ?

@Lucas-C
Copy link
Author

Lucas-C commented Jan 12, 2017

@hughsk : any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added dot option for minimatch kevincolten/uglifyify
2 participants
@Lucas-C @kevincolten