Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color not reset after every frame #4

Open
timmyRS opened this issue Mar 24, 2018 · 4 comments
Open

Color not reset after every frame #4

timmyRS opened this issue Mar 24, 2018 · 4 comments
Assignees

Comments

@timmyRS
Copy link

timmyRS commented Mar 24, 2018

The color should be reset after every frame so if you close the connection you can use your terminal normally without a different color.

@Artoria2e5
Copy link

Spitting out a colors.reset('') after each frame should fix it.

@hugomd
Copy link
Owner

hugomd commented Mar 26, 2018

I'm not sure how platform compatible colors.reset(null), but I'll try it out and push it up 🚀

Feel free to make a PR though 🙏

@hugomd hugomd self-assigned this Mar 26, 2018
@Artoria2e5
Copy link

Artoria2e5 commented Mar 26, 2018

colors.reset is part of the colors library that you are using colors for. In common ANSI speak it should be something like \u001b[0m.

@hugomd
Copy link
Owner

hugomd commented Dec 2, 2018

I've had a play with this and it seems like it doesn't effect my zsh terminal (it's probably reloading the theme or something after the command finishes), but it does affect bash and presumably other terminals..

I had a look at resetting the colors after each frame, the only issue is that killing curl midway through means you can't pipe a final chunk 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants