Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On github CI this creates .cache directory in the package #46

Closed
Gozala opened this issue Jul 29, 2020 · 0 comments · Fixed by #84
Closed

On github CI this creates .cache directory in the package #46

Gozala opened this issue Jul 29, 2020 · 0 comments · Fixed by #84

Comments

@Gozala
Copy link
Contributor

Gozala commented Jul 29, 2020

As it was discovered in multiformats/js-multibase#61 (comment) it appears that running a playwright as github action causes .cache folder to be created in the package root, which then can end up in the npm. For more details here is the configuration of github workflow

https://github.com/Gozala/web-encoding/blob/363310221c17e29fbb67b2cac046272515322164/.github/workflows/node.js.yml#L44-L67

Putting .cache in the .npmignore works around this problem, but ideally that would no be required. At least section in the Readme would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant