fix: pass channel to playwright #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 1.49.0 release of playwright has a breaking change due to a new version of headless mode in chromium. The upshot is that playwright now seems to require a channel to be passed in it's config. Without this chrome test runs fail with: ``` browserType.launchPersistentContext: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium_headless_shell-1148/chrome-linux/headless_shell ```
3 tasks
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
Nov 19, 2024
Playwright-core is breaking all chrome testing after the `1.49.0` release so override the resolved version to `1.48.0`. This can be reverted after hugomrdias/playwright-test#685 is merged.
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
Nov 19, 2024
Playwright-core is breaking all chrome testing after the `1.49.0` release so override the resolved version to `1.48.0`. This can be reverted after hugomrdias/playwright-test#685 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1.49.0 release of playwright has a breaking change due to a new version of headless mode in chromium.
The upshot is that playwright now seems to require a channel to be passed in it's config.
Without this chrome test runs fail with:
Type of change
Please delete options that are not relevant.