Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElasticPress timeout error is being caught twice #747

Open
owaincuvelier opened this issue Apr 13, 2023 · 1 comment
Open

ElasticPress timeout error is being caught twice #747

owaincuvelier opened this issue Apr 13, 2023 · 1 comment
Labels
bug Existing functionality isn't behaving as expected

Comments

@owaincuvelier
Copy link
Contributor

If an elasticsearch request times out, that error is correctly being caught and output to the PHP logs, but its being caught in two different places, causing noise in PHP logs.

  1. caught in https://github.com/humanmade/altis-cloud/blob/master/inc/namespace.php#L385
  2. also caught in https://github.com/humanmade/altis-enhanced-search/blob/master/inc/namespace.php#L388

If we can reduce the noise in the PHP logs that will make parsing errors easier for developers.
@owaincuvelier owaincuvelier added bug Existing functionality isn't behaving as expected to refine Issues needing refine labels Apr 13, 2023
@kovshenin kovshenin removed the to refine Issues needing refine label May 3, 2023
@kovshenin
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @ferschubert-hm @jerico @mikelittle @wisyhambolu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kovshenin @owaincuvelier