-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled enhanced-search does not disable ElasticPress #48
Comments
We don’t actually have the example docs for how to disable this module and that the key is actually We could rename this repo any time which makes one less point of confusion |
We'll have to rename the Packagist package as well I imagine, which will need a bit of work? |
@rmccue it's not super terrible, we'd essentially update the name in |
For the LTS policy, I think we'd need to keep it unarchived at least until v3 is out of LTS? |
Derp, yeah you're right. Not sure how well packagist copes with 2 packages driven from the same repo. |
Removed the good first issue label, aliasing module names is actually gonna be quite fiddly and possibly to be avoided. I've added docs now for how to switch it off, and the longer term solution is to rename the repo & package. |
In the meantime I've added some criteria to humanmade/altis-core#21 to help with this issue so there will at least be some basic validation. |
When
enhanced-search
is disabled at a module (or environment) level, ElasticPress is not actually disabled and displays a not configured warning in the dashboard if an ElasticSearch server has not been configured.A quick look at this module suggests that this is because the module is being registered as
search
rather thanenhanced-search
: https://github.com/humanmade/altis-enhanced-search/blob/master/load.php#L14Workaround is to define
altis.modules.search.enabled
instead ofaltis.modules.enhanced-search.enabled
.Long term solution may require adding an alias (per @roborourke slack convo) for backwards compatibility.
The text was updated successfully, but these errors were encountered: