Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependency range is uninstallable on @humanmade/eslint-config #301

Open
roborourke opened this issue Nov 10, 2022 · 3 comments
Open
Labels

Comments

@roborourke
Copy link
Contributor

Installing via npm v9, output here:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: altis-accelerate@undefined
npm ERR! Found: babel-eslint@10.1.0
npm ERR! node_modules/babel-eslint
npm ERR!   babel-eslint@"^10.0.0" from the root project
npm ERR!   peer babel-eslint@"^10.0.0" from @humanmade/eslint-config@1.1.3
npm ERR!   node_modules/@humanmade/eslint-config
npm ERR!     @humanmade/eslint-config@"^1.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer babel-eslint@"9.x" from eslint-config-react-app@3.0.8
npm ERR! node_modules/eslint-config-react-app
npm ERR!   eslint-config-react-app@"^3.0.0" from the root project
npm ERR!   peer eslint-config-react-app@"^3.0.5" from @humanmade/eslint-config@1.1.3
npm ERR!   node_modules/@humanmade/eslint-config
npm ERR!     @humanmade/eslint-config@"^1.0.0" from the root project
  • eslint-config-react-app version needs expanding or increasing to 4+
@roborourke roborourke added the bug label Nov 10, 2022
@tomjn
Copy link
Contributor

tomjn commented Nov 10, 2022 via email

@kadamwhite
Copy link
Contributor

Might make sense to at minimum do this: #252 and try to remove / "bake in" any of the standards we use, so that it's a flatter tree of "here's some rules and here's the plugins that enable them."

@kadamwhite
Copy link
Contributor

https://github.com/wikimedia/vegalite-wordpress-plugin/blob/main/.eslintrc.js I actually did something similar here, where I "rendered" all the computed rules to a single eslintrc and then removed the dependencies on the other standard. That leaves only eslint itself and the associated plugins as our dependencies https://github.com/wikimedia/vegalite-wordpress-plugin/blob/main/package.json#L49-L55

I'd love to see us fix this, and get these dependencies updated so they install properly on Node 16 / 18 / and up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants