This repository was archived by the owner on Jun 10, 2024. It is now read-only.
chore: fix caching of ignored files#111
Merged
nzakas merged 1 commit intohumanwhocodes:mainfrom Oct 19, 2023
Merged
Conversation
Contributor
|
Can you add a test for this? |
nzakas
approved these changes
Oct 19, 2023
Contributor
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
Okay, I see that we basically can't create a test because the return value is the same, it's just the amount of time it takes to get there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
getConfig()caching for ignored files.Configs for ignored files are stored as
undefinedin the cache, soif (finalConfig)was treating them as cache misses.