Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream entry icons: wrong colour #254

Closed
orangiene opened this issue Sep 8, 2021 · 9 comments
Closed

Stream entry icons: wrong colour #254

orangiene opened this issue Sep 8, 2021 · 9 comments
Assignees
Labels

Comments

@orangiene
Copy link

orangiene commented Sep 8, 2021

Bildschirmfoto 2021-09-08 um 17 57 39

After using themebuilder the icon-colour for date, location and participants is wrong.

@yurabakhtin
Copy link
Collaborator

@luke- I am not sure we should change the colors, please see what we use there:

calendar_colors

There is the code $color = $calendarEntry->getColor() ? $calendarEntry->getColor() : $this->theme->variable('info');.
I.e. the icons may have the red color from theme if a calendar entry has no defined color that I think it is impossible, only for some old version record where the calendar entry color was not implemented yet.

@luke-
Copy link
Contributor

luke- commented Sep 10, 2021

@orangiene Should we use the calendar entry color here or always use the standard icon colors?

@orangiene
Copy link
Author

@orangiene Should we use the calendar entry color here or always use the standard icon colors?

@luke- I would use the standard icon colour :)
With the calendar entry you mean the space colour, right? (in the screenshot above the turquoise colour)

@luke-
Copy link
Contributor

luke- commented Sep 13, 2021

@yurabakhtin Can you please try to use the "Default" color for such icons?
image

@yurabakhtin
Copy link
Collaborator

@luke- PR #255, but please see on default theme the color is almost invisible:

default_theme

Also I have detected the issue on updating the colors in DB from theme builder side:

theme-builder-issue

I think the DB color settings should be updated when we press "Save and Recompile Stylesheet", I will fix this in theme builder module.

@luke-
Copy link
Contributor

luke- commented Sep 13, 2021

@yurabakhtin Yes, would be great if you fix this in theme builder. I think we need to use another grey color. @orangiene Is checking other color options...

@orangiene
Copy link
Author

HI @yurabakhtin,

could you please use the same colour we use for the tags ("events", "today")?
Should be #7B7B7B.
thank you :)

@yurabakhtin
Copy link
Collaborator

@luke- @orangiene Commit 915f24c:

text-color-secondary

@yurabakhtin
Copy link
Collaborator

@luke-

Yes, would be great if you fix this in theme builder.

PR https://git.humhub.org/modules/theme-builder/-/merge_requests/5

@luke- luke- closed this as completed Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants