Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow module configuration for navigation menu #323

Closed
dantefromhell opened this issue Jul 6, 2022 · 7 comments · Fixed by #350
Closed

Allow module configuration for navigation menu #323

dantefromhell opened this issue Jul 6, 2022 · 7 comments · Fixed by #350
Assignees

Comments

@dantefromhell
Copy link
Contributor

For some modules one can configure the sortOrder attribute for the top navigation menu, as well enabling/ disabling to show the module icon in the navigation bar.

Could this behaviour be implemented for the Calendar too?

@yurabakhtin
Copy link
Collaborator

@luke- Do you agree to add menu sort order for global menu, for space menu and for profile menu like this?:

menu_settings

@luke-
Copy link
Contributor

luke- commented Dec 23, 2022

@yurabakhtin For the global menu it's ok.
I would leave out the sorting on space menu level for now.
Maybe we will find something else here in the future.

@yurabakhtin yurabakhtin self-assigned this Dec 26, 2022
@yurabakhtin yurabakhtin linked a pull request Dec 26, 2022 that will close this issue
@yurabakhtin
Copy link
Collaborator

@luke- PR #350:

menu_config

Please note on the tab "Snippet" we have the setting:

snippet-aetting

So the top menu is also hidden when the module is not activated for the current user, and in new PR I have added the new setting "Menu", i.e. the top menu will be hidden depending on these both settings, is it ok or we don't need the new menu setting "Show"?

@luke-
Copy link
Contributor

luke- commented Dec 28, 2022

@yurabakhtin Both settings are ok. Thank you. Can you please use our new "SortOrder" Field Type?

@Semir1212 Can you please check the texts of this screen:
image I'm not sure it's clear what this is about.

@yurabakhtin
Copy link
Collaborator

@luke-

Can you please use our new "SortOrder" Field Type?

Commit 8c83de3

@Semir1212
Copy link
Contributor

Show menu --> Add 'Calendar' to the main navigation @yurabakhtin

@yurabakhtin
Copy link
Collaborator

@Semir1212 Commit 442019a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants