Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calander Bug (cannot create event) #345

Closed
jayavman opened this issue Dec 14, 2022 · 3 comments · Fixed by #346
Closed

Calander Bug (cannot create event) #345

jayavman opened this issue Dec 14, 2022 · 3 comments · Fixed by #346
Assignees

Comments

@jayavman
Copy link

We can no longer add a calendar event.

Version: 1.13.0-beta.2
PHP - Version - 8.1.13
Calander : 1.4.0-beta.1

When going to spaces/calander add new calander. It fails, Error log below

yii\base\ErrorException: During inheritance of IteratorAggregate: Uncaught yii\base\ErrorException: Return type of Sabre\VObject\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/fredons/public_html/hub/protected/modules/calendar/vendor/sabre/vobject/lib/Node.php:105
Stack trace:
#0 /home/fredons/public_html/hub/protected/modules/calendar/vendor/sabre/vobject/lib/Node.php(14): yii\base\ErrorHandler->handleError(8192, 'Return type of ...', '/home/fredons/p...', 105)
#1 /home/fredons/public_html/hub/protected/vendor/composer/ClassLoader.php(571): include('/home/fredons/p...')
#2 /home/fredons/public_html/hub/protected/vendor/composer/ClassLoader.php(428): Composer\Autoload\includeFile('/home/fredons/p...')
#3 /home/fredons/public_html/hub/protected/modules/calendar/vendor/sabre/vobject/lib/Component.php(17): Composer\Autoload\ClassLoader->loadClass('Sabre\VObject\N...')
#4 /home/fredons/public_html/hub/protected/vendor/composer/ClassLoader.php(571): include('/home/fredons/p...')
#5 /home/fredons/public_html/hub/protected/vendor/composer/ClassLoader.php(428): Composer\Autoload\includeFile('/home/fredons/p...')
#6 /home/fredons/public_html/hub/protected/modules/calendar/vendor/sabre/vobject/lib/Document.php(19): Composer\Autoload\ClassLoader->loadClass('Sabre\VObject\C...')
#7 /home/fredons/public_html/hub/protected/vendor/composer/ClassLoader.php(571): include('/home/fredons/p...')
#8 /home/fredons/public_html/hub/protected/vendor/composer/ClassLoader.php(428): Composer\Autoload\includeFile('/home/fredons/p...')
#9 /home/fredons/public_html/hub/protected/modules/calendar/vendor/sabre/vobject/lib/Component/VCalendar.php(23): Composer\Autoload\ClassLoader->loadClass('Sabre\VObject\D...')
#10 /home/fredons/public_html/hub/protected/vendor/composer/ClassLoader.php(571): include('/home/fredons/p...')
#11 /home/fredons/public_html/hub/protected/vendor/composer/ClassLoader.php(428): Composer\Autoload\includeFile('/home/fredons/p...')
#12 [internal function]: Composer\Autoload\ClassLoader->loadClass('Sabre\VObject\C...')
#13 /home/fredons/public_html/hub/protected/modules/calendar/Module.php(84): class_exists('\Sabre\VObject\...')
#14 /home/fredons/public_html/hub/protected/modules/calendar/helpers/CalendarUtils.php(416): humhub\modules\calendar\Module::registerAutoloader()
#15 /home/fredons/public_html/hub/protected/modules/calendar/helpers/CalendarUtils.php(412): humhub\modules\calendar\helpers\CalendarUtils::generateUUid('calendar_event')
#16 /home/fredons/public_html/hub/protected/modules/calendar/Events.php(257): humhub\modules\calendar\helpers\CalendarUtils::generateEventUid(Object(humhub\modules\calendar\models\CalendarEntry))
#17 /home/fredons/public_html/hub/protected/modules/calendar/Events.php(244): humhub\modules\calendar\Events::onRecordBeforeUpdate(Object(yii\base\ModelEvent))
#18 [internal function]: humhub\modules\calendar\Events::onRecordBeforeInsert(Object(yii\base\ModelEvent))
#19 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/base/Event.php(312): call_user_func(Array, Object(yii\base\ModelEvent))
#20 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/base/Component.php(642): yii\base\Event::trigger('humhub\modules\...', 'beforeInsert', Object(yii\base\ModelEvent))
#21 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/db/BaseActiveRecord.php(972): yii\base\Component->trigger('beforeInsert', Object(yii\base\ModelEvent))
#22 /home/fredons/public_html/hub/protected/humhub/components/ActiveRecord.php(67): yii\db\BaseActiveRecord->beforeSave(true)
#23 /home/fredons/public_html/hub/protected/humhub/modules/content/components/ContentActiveRecord.php(430): humhub\components\ActiveRecord->beforeSave(true)
#24 /home/fredons/public_html/hub/protected/modules/calendar/models/CalendarEntry.php(374): humhub\modules\content\components\ContentActiveRecord->beforeSave(true)
#25 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/db/ActiveRecord.php(600): humhub\modules\calendar\models\CalendarEntry->beforeSave(true)
#26 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/db/ActiveRecord.php(570): yii\db\ActiveRecord->insertInternal(NULL)
#27 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/db/BaseActiveRecord.php(676): yii\db\ActiveRecord->insert(true, NULL)
#28 /home/fredons/public_html/hub/protected/modules/calendar/models/CalendarEntry.php(988): yii\db\BaseActiveRecord->save()
#29 /home/fredons/public_html/hub/protected/modules/calendar/models/forms/CalendarEntryForm.php(464): humhub\modules\calendar\models\CalendarEntry->saveEvent()
#30 [internal function]: humhub\modules\calendar\models\forms\CalendarEntryForm->humhub\modules\calendar\models\forms{closure}(Object(yii\db\Connection))
#31 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/db/Connection.php(818): call_user_func(Object(Closure), Object(yii\db\Connection))
#32 /home/fredons/public_html/hub/protected/modules/calendar/models/forms/CalendarEntryForm.php(497): yii\db\Connection->transaction(Object(Closure))
#33 /home/fredons/public_html/hub/protected/modules/calendar/controllers/EntryController.php(227): humhub\modules\calendar\models\forms\CalendarEntryForm->save()
#34 [internal function]: humhub\modules\calendar\controllers\EntryController->actionEdit(NULL, NULL, NULL, '1', NULL, NULL)
#35 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array(Array, Array)
#36 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/base/Controller.php(178): yii\base\InlineAction->runWithParams(Array)
#37 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/base/Module.php(552): yii\base\Controller->runAction('edit', Array)
#38 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/web/Application.php(103): yii\base\Module->runAction('calendar/entry/...', Array)
#39 /home/fredons/public_html/hub/protected/vendor/yiisoft/yii2/base/Application.php(384): yii\web\Application->handleRequest(Object(humhub\components\Request))
#40 /home/fredons/public_html/hub/index.php(25): yii\base\Application->run()
#41 {main} in /home/fredons/public_html/hub/protected/modules/calendar/vendor/sabre/vobject/lib/Node.php:14
Stack trace:
#0 [internal function]: yii\base\ErrorHandler->handleFatalError()
#1 {main}

@yurabakhtin
Copy link
Collaborator

@luke- Fixed in PR #346 by updating composer libraries to newer version for php 8.1+.

@luke-
Copy link
Contributor

luke- commented Dec 16, 2022

@yurabakhtin I am not sure if we should delete the master tests. I think if we merge soon develop in master, we forget them then in the modules to restore the file.

Let's rather let this single test fail as long as develop works.

@yurabakhtin
Copy link
Collaborator

@luke- I have reverted the master tests in commit bd3cb19.

Ok, I will never delete the master and develop tests from modules even if they have errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants