Canceled Events: add CSS class #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This CSS would work for month, week, day and list view and only strike through the event title, not the time. |
|
@felixhahnweilheim Thanks for the PR. Can you please add a screenshot with the strikethrou? Then we can discuss whether to add it. |
|
|
|
@Eladnarlea What do you think? |
|
@luke- I like the idea and think it is useful information. Do we need the extra @felixhahnweilheim do you suggest to leave the time as it is, or is it not possible to strike it through as well? this is how it looks in apple calendar. |
|
I have updated the PR to the following:
|
luke-
approved these changes
Feb 19, 2024
luke-
approved these changes
Feb 19, 2024
|
@felixhahnweilheim @Eladnarlea Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CSS class 'canceled' to canceled events. This way themes can manipulate the background color of the event or strike through the title.
Related: #320
Please let me know if I also should add CSS to strike through the title.