Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Cookie Banner #93

Open
ArchBlood opened this issue Nov 24, 2024 · 6 comments
Open

Enhancement Cookie Banner #93

ArchBlood opened this issue Nov 24, 2024 · 6 comments

Comments

@ArchBlood
Copy link
Contributor

I'd like to introduce something rather different when it comes to the Cookie notice, currently it only shows a small notice without being able to allow user preferences, so I'd like to propose this to be implemented, I've been working on a small demo and hope that it's up to HumHub's standards for this very thing?

UI Examples

Screenshot_1
Screenshot_2

@luke-
Copy link
Collaborator

luke- commented Nov 25, 2024

It's basically interesting, but we only use functional cookies in HumHub atm.

There would also need to be an admin interface/module api here to manage individual cookies if necessary.

@ArchBlood
Copy link
Contributor Author

It's basically interesting, but we only use functional cookies in HumHub atm.

There would also need to be an admin interface/module api here to manage individual cookies if necessary.

I also thought about this as well, we could replace the Cookie notification page with something like this? Which handles what is seen in the cookie banner.
Screenshot_1

@luke-
Copy link
Collaborator

luke- commented Nov 25, 2024

Yes, something like that would be needed.
How would it work if you reject a cookie?

@ArchBlood
Copy link
Contributor Author

Yes, something like that would be needed.
How would it work if you reject a cookie?

That's a good question, currently I think it would work the same as it already does, personally I think we should make an event similar to the export so that other modules can be injected into it. 🤔

@luke-
Copy link
Collaborator

luke- commented Nov 25, 2024

Currently, it is more of a hint than a way to manage and, if necessary, disable individual cookies.
Somehow, this status would have to be forwarded to the respective module.

@ArchBlood
Copy link
Contributor Author

Currently, it is more of a hint than a way to manage and, if necessary, disable individual cookies. Somehow, this status would have to be forwarded to the respective module.

I can look into this more when I have the time to implement such a change, but would probably be more of a core thing to look at rather than just the legal tools module, although I'd like to focus on finishing #89 if possible, at the moment it works as needed, although the JavaScript could probably be looked at for a better implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants