Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checklist in Wall Entry #244

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

felixhahnweilheim
Copy link
Contributor

Adds the task checklist to wall entries.

  • Task description and checklist are wrapped in <div ... "data-ui-show-more">, so the wall entry doesn't get too long
  • added margin-bottom: 10px to the TaskRoleInfoBox (to get more or less the same spacing for all elements)

Sometimes the checklist is more important than the description and contains important information. So it should be shown in the stream entry.

fixes #223

@luke-
Copy link
Contributor

luke- commented Nov 20, 2023

@felixhahnweilheim Thanks. Can you please add a screenshot?

@felixhahnweilheim
Copy link
Contributor Author

felixhahnweilheim commented Nov 20, 2023

Yes, of course:

Screenshot_20231120_194121_Chrome.jpg

Screenshot_20231120_194146_Chrome.jpg

@luke-
Copy link
Contributor

luke- commented Nov 20, 2023

@Eladnarlea What do you think about the upcoming Wall Entry redesign? Do we want to take it that way for now? Or better wait?

@Eladnarlea
Copy link

It gives the tasks wall entry more originality. If you like, I can check the design briefly, @luke- ? We would need to set a limit on the checkbox entries displayed.

@luke-
Copy link
Contributor

luke- commented Nov 28, 2023

@Eladnarlea Ok, please check. Yes, we should limit the height/number of checkboxes in the wall entries.

@Eladnarlea
Copy link

@felixhahnweilheim do you have a test account where I can quickly test this behaviour? :)

@felixhahnweilheim
Copy link
Contributor Author

@Eladnarlea Sorry for the late response. I have sent you a test account via PM in the HumHub Community.

@Eladnarlea
Copy link

I would:

  • restrict the max-height to 180px instead of 380 px
  • add more margin-bottom to Checklist (16px?)
  • remove icon before checklist
  • align checklist-headline and checklist to the left without indent
Screenshot 2024-09-17 at 9 51 47 AM

Screenshot 2024-09-18 at 11 27 24 AM

in general @luke- I would discard off the read more, as there is a button to view the task anyways, close underneath the read more... just an advice.

@felixhahnweilheim
Copy link
Contributor Author

restrict the max-height to 180px instead of 380 px

done

add more margin-bottom to Checklist (16px?)

done

remove icon before checklist

The icon is added in the TaskCheckList widget.
If the icon should still be shown in the main task view and only removed in the stream entry, we probably have to add an option to the TaskCheckList widget (e.g. "showIcon" that defaults to true).

align checklist-headline and checklist to the left without indent

I did this now simply by removing the relevant CSS lines. But the same question: Should the indent remain in the main task view? Then I'll add CSS that only prevents it in the stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Task List Checkpoints to Space Stream Post
3 participants