Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button "Log out" doesn't prevent pjax #29

Closed
yurabakhtin opened this issue Jul 20, 2021 · 2 comments
Closed

Button "Log out" doesn't prevent pjax #29

yurabakhtin opened this issue Jul 20, 2021 · 2 comments
Assignees
@luke-
Labels
bug Something isn't working

Comments

@yurabakhtin
Copy link
Collaborator

@luke- Why did you modified the button "Log out" here 7375d22#diff-6b50c5c79652c49abaff914c86163ba66bb7e98736f436d6d440a588b365ab6aR45 ?

button_logout

At least the attribute 'data-pjax' => false is wrong, because correct is 'data-pjax-prevent' => 1.
@yurabakhtin yurabakhtin added the bug Something isn't working label Jul 20, 2021
@yurabakhtin yurabakhtin mentioned this issue Jul 20, 2021
Merged
@yurabakhtin
Copy link
Collaborator Author

@luke-

At least the attribute 'data-pjax' => false is wrong, because correct is 'data-pjax-prevent' => 1.

PR #30

@luke-
Copy link
Contributor

luke- commented Jul 20, 2021

@yurabakhtin Thanks!

@luke- luke- closed this as completed Jul 20, 2021
@ArchBlood ArchBlood mentioned this issue Jul 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luke- luke-

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luke- @yurabakhtin