Refactor deprecated setModalLoader(); usage

[luke-]

No description provided.

[yurabakhtin]

@luke- Core PR humhub/humhub#6389 - I have removed the deprecated JS function and implemented one new humhub.require("ui.modal").footerLoader() instead.

Then I have updated this module in the PR #35, but it requires new HumHub vesion 1.15, if it is not ok, I can try to update the JS code without using the new JS function footerLoader().

[luke-]

@yurabakhtin The footer loader of the updater is very special. Do you think its useful to provide a separate footerLoader() in the core, which is only used by the updater?

Wouldn't it be better to implement such a loader only in the updater?

Then we would not have problems with version dependencies.

[yurabakhtin]

@luke-

The footer loader of the updater is very special. Do you think its useful to provide a separate footerLoader() in the core, which is only used by the updater?

It is used also in 3 core places:

• Module options "Set as default" - https://github.com/humhub/humhub/pull/6389/files#diff-0f1bd2208078de651ee53bb3e6b2a2cef3f4e8a42e8c9e6eaab650ee7336ee17R53
• Request a space membership - https://github.com/humhub/humhub/pull/6389/files#diff-a2b943a47fd9c71957a29c7e44da454e2cf786ecc3930d9bb6807ac07a637637R41
• Ajax page loader(e.g. members list) - https://github.com/humhub/humhub/pull/6389/files#diff-205955478539baf71a80495e6f870b942bbd2338b13f45d763a0ae13f23cff04R28

So I moved the deprecated function setModalLoader() from static/js/humhub/humhub.ui.additions.js to static/js/humhub/humhub.ui.modal.js. Also I have deleted the function from the file static/js/humhub/legacy/app.js because I didn't find where it was used.

Wouldn't it be better to implement such a loader only in the updater?

Yes, I can implement/copy the same JS code from humhub.require("ui.modal").footerLoader() to this module updater, so we can revert the min version to 1.0 as it was before. Should I do this?

[luke-]

@yurabakhtin Sorry, missed that in my review. If the footerLoader(); is also used in the core, your approach is fine.

[luke-]

@yurabakhtin FYI, I've added the core change in the new migration doc: humhub/humhub@a2e708f - Please also add changes here.

[yurabakhtin]

@luke-

FYI, I've added the core change in the new migration doc: humhub/humhub@a2e708f - Please also add changes here.

Do you mean to update the line Removed deprecated javascript method setModalLoader() somehow, or is it info for me to update the file in future when I will do some similar changes?

[yurabakhtin]

Yes, I can implement/copy the same JS code from humhub.require("ui.modal").footerLoader() to this module updater, so we can revert the min version to 1.0 as it was before. Should I do this?

@luke- Should I do something with this module "Updater" in order to don't increase the min version to 1.15?

[luke-]

@luke-

FYI, I've added the core change in the new migration doc: humhub/humhub@a2e708f - Please also add changes here.

Do you mean to update the line Removed deprecated javascript method setModalLoader() somehow, or is it info for me to update the file in future when I will do some similar changes?

It's just a info for you, for future similar changes.

[luke-]

Yes, I can implement/copy the same JS code from humhub.require("ui.modal").footerLoader() to this module updater, so we can revert the min version to 1.0 as it was before. Should I do this?

@luke- Should I do something with this module "Updater" in order to don't increase the min version to 1.15?

No, it's fine, I'll merge the PR. Thanks