Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.x throws error on HumHub 1.15+ #42

Closed
luke- opened this issue Dec 14, 2023 · 4 comments
Closed

v2.1.x throws error on HumHub 1.15+ #42

luke- opened this issue Dec 14, 2023 · 4 comments
Assignees
Labels

Comments

@luke-
Copy link
Contributor

luke- commented Dec 14, 2023

For a better update process, it would be good to release a version 2.1.13 of the updater module, which simply redirects to the marketplace instead of throwing an error on HumHub version 1.15+.

image

@dreua
Copy link

dreua commented Dec 14, 2023

Does that mean that the updater is not needed for those humhub versions?

Edit: sorry, probably just needs an update in this case.

@luke-
Copy link
Contributor Author

luke- commented Dec 14, 2023

@dreua The update itself is working, Just an error after the successful update.

@yurabakhtin
Copy link
Contributor

@luke- I have created the changes in the branch https://github.com/humhub/updater/tree/fix/42-redirect-to-marketplace, but we should not create PR because we don't need to merge it to master branch.

I think we should create a new release 2.1.13 directly from the branch fix/42-redirect-to-marketplace, right?

Commit ef63a45 - please note I have updated min version to 1.4 because I find the controller protected/humhub/modules/marketplace/controllers/BrowseController.php was added here humhub/humhub@4ba5bcb#diff-f62e14ddc993740cf1de865bc72775676a84d8d70b56f1261f42f585acd95cd5,
I guess it was done in version 1.3.14 (June 26, 2019) or later.

@luke-
Copy link
Contributor Author

luke- commented Dec 14, 2023

Can you create a PR into the v2.1 branch?
https://github.com/humhub/updater/tree/v2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants