You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have currently rewritten part of the svelte-shadcn code locally, specifically the Sheet.Root and Sheet.Overlay components. By placing the state in a custom Root component, it can be closed in the overlay. I believe this is one of the long-term issues with bits-ui's support for shadow dom, considering that the author seems to be waiting for the implementation of new Svelte features and has already removed shadow dom support from 1.0 plan. Should we consider directly fixing such errors in shadcn, or do non-UI errors have to wait for upstream fixes?
ref: huntabyte/bits-ui#828 (comment)
Reproduction
git clone https://github.com/rxliuli/shadcn-sheet-shadow-dom-error-demo
pnpm i && pnpm dev
The text was updated successfully, but these errors were encountered:
rxliuli
changed the title
bug: Clicking the overlay in the shadow DOM does not close it.
bug(Sheet/Dialog): Clicking the overlay in the shadow DOM does not close it.
Feb 4, 2025
Shadow DOM support for Bits UI is a bit flakey at the moment due to how we get references to the various nodes using their IDs which enables us to support both the regular component and the child snippet.
Once this lands, we should be able to have complete shadow DOM support: sveltejs/svelte#15000
Describe the bug
Kapture.2025-02-04.at.10.45.02.mp4
I have currently rewritten part of the svelte-shadcn code locally, specifically the Sheet.Root and Sheet.Overlay components. By placing the state in a custom Root component, it can be closed in the overlay. I believe this is one of the long-term issues with bits-ui's support for shadow dom, considering that the author seems to be waiting for the implementation of new Svelte features and has already removed shadow dom support from 1.0 plan. Should we consider directly fixing such errors in shadcn, or do non-UI errors have to wait for upstream fixes?
ref: huntabyte/bits-ui#828 (comment)
Reproduction
git clone https://github.com/rxliuli/shadcn-sheet-shadow-dom-error-demo pnpm i && pnpm dev
Logs
System Info
Severity
blocking an upgrade
The text was updated successfully, but these errors were encountered: