Commit 30ec2e9
[RPP] Sort markers before appending
Markers (LCP, FCP, etc.) can come from different sources
(ExtensionDataHandler & PageLoadMetricsHandler). The
FlameChart::drawMarkers implementation assumes these markers are
appended in order so that they can be drawn correctly [1]. So, before
we append the concatenation of markers from both sources we need to
sort them.
This fixes a bug I noticed with extension markers being drawn on an
incorrect x position. [2]
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/ui/legacy/components/perf_ui/FlameChart.ts;l=2635;drc=d9e4f0e53f58da1f8d8d84fa0d2e661226dd2d73
[2] https://screenshot.googleplex.com/5LiDg9Uv7LA8sSg
Fixed: 357056787
Change-Id: Ie60ad9dd92d7269f0fb5fda80af1114105160f8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5757144
Auto-Submit: Andres Olivares <andoli@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>1 parent d690aeb commit 30ec2e9
1 file changed
+2
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
| 109 | + | |
109 | 110 | | |
110 | 111 | | |
111 | 112 | | |
| |||
0 commit comments