Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script doesn't work by default #56

Open
gnzlbg opened this issue Jun 17, 2016 · 1 comment
Open

Script doesn't work by default #56

gnzlbg opened this issue Jun 17, 2016 · 1 comment

Comments

@gnzlbg
Copy link

gnzlbg commented Jun 17, 2016

When using the script it should work by default. Right now I get:

error: Package bitwise v0.1.0 (file:///home/travis/build/gnzlbg/bitwise) does not have these features: unstable

If I comment out the following line:

 - TRAVIS_CARGO_NIGHTLY_FEATURE=nightly

and

error: Package bitwise v0.1.0 (file:///home/travis/build/gnzlbg/bitwise) does not have these features: nightly

if I leave it on.

One solution is to set that line to the empty string

- TRAVIS_CARGO_NIGHTLY_FEATURE=""

but that should be made more obvious. IMO it would be better if the default would be for repos without nightly features to compile as is on nightly, and if some repos need unstable or nightly features the script should explain how to do that, and provide the lines commented out so that just un-commenting them works:

 #- TRAVIS_CARGO_NIGHTLY_FEATURE=nightly
 #- TRAVIS_CARGO_NIGHTLY_FEATURE=unstable
@Ryman
Copy link

Ryman commented Jun 17, 2016

Could probably use cargo metadata for this:

cargo metadata | jq ".packages[0].features"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants