Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs with parentesis break markdown links #1380

Closed
danicatalan opened this issue Nov 21, 2017 · 2 comments
Closed

URLs with parentesis break markdown links #1380

danicatalan opened this issue Nov 21, 2017 · 2 comments

Comments

@danicatalan
Copy link
Contributor

danicatalan commented Nov 21, 2017

How to reproduce it

Add a filter URL to a link, for example http://localhost:3000/en/library/?q=(order:desc,sort:metadata.date)

[This will break closing on the first parentesis](http://localhost:3000/en/library/?q=(order:desc,sort:metadata.date))

@daneryl
Copy link
Collaborator

daneryl commented Nov 22, 2017

@RafaPolit @danicatalan its a Marked.js issue, markedjs/marked#619, its a difficult one explained on that issue, also the maintainer seems that is not active for a long time, markedjs/marked#756
i think we should change the library we use for markdown, maybe https://github.com/markdown-it/markdown-it ?

@danicatalan danicatalan removed the NEW label Nov 28, 2017
@kjantin
Copy link
Contributor

kjantin commented Dec 11, 2017

Idea for solution: create custom hook for internal URLs

@konzz konzz self-assigned this Mar 29, 2018
@konzz konzz mentioned this issue Mar 29, 2018
8 tasks
@daneryl daneryl closed this as completed Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants