Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove url-join, implement limited substitute #4562

Open
LaszloKecskes opened this issue Apr 28, 2022 · 0 comments
Open

Remove url-join, implement limited substitute #4562

LaszloKecskes opened this issue Apr 28, 2022 · 0 comments

Comments

@LaszloKecskes
Copy link
Contributor

The new major version of url-join is ESM only, causing problems while importing packages (see #4517). Since we do not use this in a lot of places and only for simple use cases, the team has decided to remove the package, and implement a limited (but tested) substitute in Uwazi for our specific use cases.

  • look for cases where url-join is used in the code.
  • implement a substitute covering our cases, as it seems sensible.
  • remove url-join and @types/url-join.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants