You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, I am very glad that this library exists, and thanks for all your efforts to implement this.
I found a critical issue.
The deinit function is not called in the viewcontroller I've added as contentController to PopupViewController class.
This means memory is not deallocated.
I've played a little with your provided example, and the same happens on your end.
Also, even if I am adding this in your parent class, deinit is not called in child class:
The text was updated successfully, but these errors were encountered:
AndreiBoariu
changed the title
Deinit not called on class I added as controller to PopupController
Deinit not called on class I added as contentController to PopupController
Jan 19, 2023
Hi,
First of all, I am very glad that this library exists, and thanks for all your efforts to implement this.
I found a critical issue.
The
deinit
function is not called in the viewcontroller I've added ascontentController
to PopupViewController class.This means memory is not deallocated.
I've played a little with your provided example, and the same happens on your end.
Also, even if I am adding this in your parent class, deinit is not called in child class:
`deinit {
print("PopupViewController deinit")
Does anybody have any clue ?
Appreciate
The text was updated successfully, but these errors were encountered: