inspector: roll inspector_protocol

Roll the inspector_protocol library to match V8's inspector_protocol
revision.

Update the node inspector to use the new `crdtp` protocol library.

PR-URL: nodejs#56649
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Author: legendecas

src/inspector/network_agent.cc

@@ -53,12 +53,12 @@ void NetworkAgent::Wire(UberDispatcher* dispatcher) {
 
 DispatchResponse NetworkAgent::enable() {
   inspector_->Enable();
-  return DispatchResponse::OK();
+  return DispatchResponse::Success();
 }
 
 DispatchResponse NetworkAgent::disable() {
   inspector_->Disable();
-  return DispatchResponse::OK();
+  return DispatchResponse::Success();
 }
 
 void NetworkAgent::requestWillBeSent(
@@ -76,9 +76,11 @@ void NetworkAgent::requestWillBeSent(
   request->getString("method", &method);
 
   ErrorSupport errors;
+  errors.Push();
+  errors.SetName("headers");
   auto headers =
       Network::Headers::fromValue(request->getObject("headers"), &errors);
-  if (errors.hasErrors()) {
+  if (!errors.Errors().empty()) {
     headers = std::make_unique<Network::Headers>(DictionaryValue::create());
   }
 
@@ -105,9 +107,11 @@ void NetworkAgent::responseReceived(
   response->getString("statusText", &statusText);
 
   ErrorSupport errors;
+  errors.Push();
+  errors.SetName("headers");
   auto headers =
       Network::Headers::fromValue(response->getObject("headers"), &errors);
-  if (errors.hasErrors()) {
+  if (!errors.Errors().empty()) {
     headers = std::make_unique<Network::Headers>(DictionaryValue::create());
   }
 

src/inspector/node_inspector.gypi

@@ -15,6 +15,8 @@
       'src/inspector_socket_server.h',
       'src/inspector/main_thread_interface.cc',
       'src/inspector/main_thread_interface.h',
+      'src/inspector/node_json.cc',
+      'src/inspector/node_json.h',
       'src/inspector/node_string.cc',
       'src/inspector/node_string.h',
       'src/inspector/runtime_agent.cc',
@@ -29,6 +31,30 @@
       'src/inspector/network_agent.h',
       'src/inspector/worker_inspector.cc',
       'src/inspector/worker_inspector.h',
+
+      '<(protocol_tool_path)/crdtp/cbor.cc',
+      '<(protocol_tool_path)/crdtp/cbor.h',
+      '<(protocol_tool_path)/crdtp/dispatch.cc',
+      '<(protocol_tool_path)/crdtp/dispatch.h',
+      '<(protocol_tool_path)/crdtp/error_support.cc',
+      '<(protocol_tool_path)/crdtp/error_support.h',
+      '<(protocol_tool_path)/crdtp/export.h',
+      '<(protocol_tool_path)/crdtp/find_by_first.h',
+      '<(protocol_tool_path)/crdtp/frontend_channel.h',
+      '<(protocol_tool_path)/crdtp/json.cc',
+      '<(protocol_tool_path)/crdtp/json.h',
+      '<(protocol_tool_path)/crdtp/json_platform.cc',
+      '<(protocol_tool_path)/crdtp/json_platform.h',
+      '<(protocol_tool_path)/crdtp/maybe.h',
+      '<(protocol_tool_path)/crdtp/parser_handler.h',
+      '<(protocol_tool_path)/crdtp/protocol_core.cc',
+      '<(protocol_tool_path)/crdtp/protocol_core.h',
+      '<(protocol_tool_path)/crdtp/serializable.cc',
+      '<(protocol_tool_path)/crdtp/serializable.h',
+      '<(protocol_tool_path)/crdtp/span.cc',
+      '<(protocol_tool_path)/crdtp/span.h',
+      '<(protocol_tool_path)/crdtp/status.cc',
+      '<(protocol_tool_path)/crdtp/status.h',
     ],
     'node_inspector_generated_sources': [
       '<(SHARED_INTERMEDIATE_DIR)/src/node/inspector/protocol/Forward.h',
@@ -44,23 +70,11 @@
       '<(SHARED_INTERMEDIATE_DIR)/src/node/inspector/protocol/Network.h',
     ],
     'node_protocol_files': [
-      '<(protocol_tool_path)/lib/Allocator_h.template',
-      '<(protocol_tool_path)/lib/base_string_adapter_cc.template',
-      '<(protocol_tool_path)/lib/base_string_adapter_h.template',
-      '<(protocol_tool_path)/lib/DispatcherBase_cpp.template',
-      '<(protocol_tool_path)/lib/DispatcherBase_h.template',
-      '<(protocol_tool_path)/lib/encoding_cpp.template',
-      '<(protocol_tool_path)/lib/encoding_h.template',
-      '<(protocol_tool_path)/lib/ErrorSupport_cpp.template',
-      '<(protocol_tool_path)/lib/ErrorSupport_h.template',
       '<(protocol_tool_path)/lib/Forward_h.template',
-      '<(protocol_tool_path)/lib/FrontendChannel_h.template',
-      '<(protocol_tool_path)/lib/Maybe_h.template',
       '<(protocol_tool_path)/lib/Object_cpp.template',
       '<(protocol_tool_path)/lib/Object_h.template',
-      '<(protocol_tool_path)/lib/Parser_cpp.template',
-      '<(protocol_tool_path)/lib/Parser_h.template',
       '<(protocol_tool_path)/lib/Protocol_cpp.template',
+      '<(protocol_tool_path)/lib/ValueConversions_cpp.template',
       '<(protocol_tool_path)/lib/ValueConversions_h.template',
       '<(protocol_tool_path)/lib/Values_cpp.template',
       '<(protocol_tool_path)/lib/Values_h.template',
@@ -77,6 +91,7 @@
     '<@(node_inspector_sources)',
   ],
   'include_dirs': [
+    '<(protocol_tool_path)',
     '<(SHARED_INTERMEDIATE_DIR)/include', # for inspector
     '<(SHARED_INTERMEDIATE_DIR)',
     '<(SHARED_INTERMEDIATE_DIR)/src', # for inspector
@@ -112,6 +127,7 @@
       'action': [
         '<(python)',
         'tools/inspector_protocol/code_generator.py',
+        '--inspector_protocol_dir', 'tools/inspector_protocol/',
         '--jinja_dir', '<@(protocol_tool_path)',
         '--output_base', '<(SHARED_INTERMEDIATE_DIR)/src/',
         '--config', 'src/inspector/node_protocol_config.json',