Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOsKeychainError is not documented as far as I can tell #24

Closed
samuela opened this issue Mar 20, 2019 · 6 comments
Closed

MacOsKeychainError is not documented as far as I can tell #24

samuela opened this issue Mar 20, 2019 · 6 comments
Assignees

Comments

@samuela
Copy link

samuela commented Mar 20, 2019

When the user denies keychain access on macOS, keyring returns a MacOsKeychainError error, which would be fine except that it's not really clear how this works since it's not documented anywhere here: https://docs.rs/keyring/0.6.1/keyring/struct.Keyring.html. I tried searching the docs for the string "MacOsKeychainError" but there weren't any results: https://docs.rs/keyring/0.6.1/keyring/struct.Keyring.html?search=MacOsKeychainError.

Also, how can one tell the difference between the user denying access vs other types of keychain errors in this case?

@hwchen
Copy link
Owner

hwchen commented Mar 22, 2019

Hi, sorry you couldn't find the error in the docs. Perhaps the docs are generated on linux, and so windows-specific and mac-specific errors are not rendered.

As for the non-specificity of the error, it's an issue I'd like to deal with soon. I have some more bandwidth coming up (as well as access to a mac again).

#22

@hwchen
Copy link
Owner

hwchen commented Mar 22, 2019

rust-lang/rust#1998

Looks like cross-platform documentation is not-yet-solved.
I'll think about putting some of this missing documentation into the readme.

@hwchen
Copy link
Owner

hwchen commented Apr 20, 2019

the mac keychain error has been improved, see #22. Should be ready in the next version.

@hwchen
Copy link
Owner

hwchen commented Apr 21, 2019

added a note in the readme that a cargo command can be run to get docs locally. Next step would be to render docs on each platform and host them somewhere myself.

@adobeDan
Copy link
Collaborator

This is a good candidate for addressing in #70. We should at least be able to say what the underlying errors are in each of the platforms in a cross-platform way.

@brotskydotcom
Copy link
Collaborator

closed with merge of #70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants