Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: fix issues of errorlint, forcetypeassert... #1037

Merged
merged 1 commit into from
Nov 15, 2023
Merged

lint: fix issues of errorlint, forcetypeassert... #1037

merged 1 commit into from
Nov 15, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Nov 12, 2023 •
edited
Loading

Solved issues and/or description of the change

introducing new linters and fix issues, see also #1031 :

  • errorlint
  • forcetypeassert
  • nakedret
  • nonamedreturns
  • bodyclose
  • containedctx
  • dogsled
  • errchkjson
  • gci
  • gocritic
  • noctx
  • predeclared
  • thelper
  • usestdlibvars

additionally fixes:

  • AnalogRead() in spi/mcp3x0x drivers

Manual test

  • OS and Version (Win/Mac/Linux): Linux
  • Adaptor(s) and/or driver(s): Tinkerboard, pwm output, ADS1115, AnalogSensor, TemperaturSensor

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas force-pushed the fix/errorlint branch 15 times, most recently from ae3db0d to 6be6cf3 Compare November 15, 2023 19:21
@gen2thomas gen2thomas marked this pull request as ready for review November 15, 2023 19:51
@gen2thomas gen2thomas merged commit 7f78ede into hybridgroup:dev Nov 15, 2023
5 checks passed
@gen2thomas gen2thomas deleted the fix/errorlint branch November 15, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gen2thomas