Build(go, deps): switch to Go 1.18 and update modules #940
Conversation
gen2thomas
force-pushed
the
feature/go_118
branch
from
7eadbd4
to
b236b36
Compare
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.0 to 1.8.3. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.0...v1.8.3) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
gen2thomas
force-pushed
the
feature/go_118
branch
from
b236b36
to
5533488
Compare
gen2thomas
force-pushed
the
feature/go_118
branch
from
19c0a73
to
7569161
Compare
|
Hi @gedw99, please could you have a look at this PR for the changed nats parts in test. Thanks, Thomas |
what exactly do you want me to concentrate on ? I guess this is a response to the email i sent you ? |
|
Hi @gedw99 , there were some changes between "github.com/nats-io/nats.go v1.25.0" and "v1.26.0", which results in failing related tests at gobot. So I changed some test code after a static review of the changes in "nats.go", without any knowledge of NATS in general. As far as I can see it is related to certificate handling. I had zero experience with NATS before this change. Than I remembered your email and it would be nice if you could take a look at it. Maybe the 3 tests are now useless after my change or tests the wrong part of code. Thanks Thomas |
|
ok understand - I just cant right now. totally loaded up. will be happy to help later but just cant not. |
Thanks for your fast response, so I simply merge this PR, because there were no changes in productive code. One can then also make the improvements sometime later in a separate PR. |
Solved issues and/or description of the change
Update to a newer Go version 1.18, because gobot use the most recent version-2, see #919 .
Fix linter finding in nats-tests:
SA1019: o.TLSConfig.RootCAs.Subjects has been deprecated since Go 1.18: if s was returned by SystemCertPool, Subjects will not include the system roots. (staticcheck)Manual test
Linux
Checklist
make test)make fmt_check)