Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(linters, format): go fmt and opinionated list of linters #962

Merged
merged 1 commit into from
Jun 18, 2023
Merged

build(linters, format): go fmt and opinionated list of linters #962

merged 1 commit into from
Jun 18, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Jun 18, 2023 •
edited
Loading

Solved issues and/or description of the change

  • golint cleanup #544 by running "gofmt -l -s -w ."
  • adjust Makefile for this call
  • update golangci-lint to 1.53.3
  • add some more linters
  • add a TODO list for useful, but currently failing linters

Manual test

no

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas changed the title build(linters): format findings fixed and opinionated list of linters build(linters, format): format findings fixed and opinionated list of linters Jun 18, 2023
@gen2thomas gen2thomas changed the title build(linters, format): format findings fixed and opinionated list of linters build(linters, format): go fmt and opinionated list of linters Jun 18, 2023
@gen2thomas gen2thomas marked this pull request as ready for review June 18, 2023 16:10
@gen2thomas gen2thomas merged commit 1e2a4d8 into hybridgroup:dev Jun 18, 2023
1 check passed
@gen2thomas gen2thomas deleted the feature/opinionated_todo_linters branch June 18, 2023 16:10
gen2thomas added a commit to gen2thomas/gobot that referenced this pull request Jul 6, 2023
@gen2thomas
build(linters): list of linter todo's (hybridgroup#962)
0648f66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gen2thomas