Refactor to use Laravel validation for range validation

Author: caendesilva

packages/framework/src/Console/Commands/MakePublicationTypeCommand.php

@@ -90,7 +90,7 @@ protected function captureFieldsDefinitions(): Collection
             if ($type < 10) {
                 do {
                     $fieldData['min'] = trim($this->askWithValidation('min', 'Min value (for strings, this refers to string length)', ['required', 'string'], 0));
-                    $fieldData['max'] = trim($this->askWithValidation('max', 'Max value (for strings, this refers to string length)', ['required', 'string'], 0));
+                    $fieldData['max'] = trim($this->askWithValidation('max', 'Max value (for strings, this refers to string length)', ['required', 'string', 'gt:'.(int)$fieldData['min']], 0));
                     $lengthsValid = $this->validateLengths($fieldData['min'], $fieldData['max']);
                 } while (! $lengthsValid);
             } else {

packages/framework/tests/Feature/Commands/MakePublicationTypeCommandTest.php

@@ -86,4 +86,17 @@ public function test_command_creates_publication_type()
 
         // TODO: Assert Blade templates were created?
     }
+
+    public function test_cannot_create_field_with_lower_max_than_min_value()
+    {
+        $this->artisan('make:publicationType test-publication')
+            ->expectsQuestion('Field name', 'foo')
+            ->expectsQuestion('Field type', 'foo')
+            ->expectsQuestion('Min value (for strings, this refers to string length)', 10)
+            ->expectsQuestion('Max value (for strings, this refers to string length)', 5)
+            ->expectsQuestion('Min value (for strings, this refers to string length)', 5)
+            ->expectsQuestion('Max value (for strings, this refers to string length)', 10)
+
+             ->assertSuccessful();
+    }
 }