Skip to content

Commit 4ccc8d2

Browse files
authored
Merge pull request #1759 from hydephp/deprecate-the-base-url-not-set-exception-class
[1.x] Deprecate the `BaseUrlNotSetException` class
2 parents 44678c2 + bc4aec6 commit 4ccc8d2

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

RELEASE_NOTES.md

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ This serves two purposes:
2424

2525
### Deprecated
2626
- Deprecated the global `unslash()` function, replaced with the existing namespaced `\Hyde\unslash()` function in https://github.com/hydephp/develop/pull/1753
27+
- Deprecated the `BaseUrlNotSetException` class in https://github.com/hydephp/develop/pull/1759
2728

2829
### Removed
2930
- The Git version is no longer displayed in the debug screen and dashboard in https://github.com/hydephp/develop/pull/1756

packages/framework/src/Foundation/Kernel/Hyperlinks.php

+1
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ public function url(string $path = ''): string
162162
}
163163

164164
// User is trying to get the base URL, but it's not set
165+
// This exception is deprecated and will be removed in v2.0.0, and we will return null instead.
165166
throw new BaseUrlNotSetException();
166167
}
167168

packages/framework/src/Framework/Exceptions/BaseUrlNotSetException.php

+3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66

77
use Exception;
88

9+
/**
10+
* @deprecated This exception will be removed in v2.0.0.
11+
*/
912
class BaseUrlNotSetException extends Exception
1013
{
1114
/** @var string */

0 commit comments

Comments
 (0)