Skip to content

Commit 7855edb

Browse files
authored
Merge branch 'master' into update-readme-badges-to-lead-to-something
2 parents 3075407 + b31f3e3 commit 7855edb

File tree

5 files changed

+21
-20
lines changed

5 files changed

+21
-20
lines changed

packages/framework/src/Framework/Features/Documentation/SemanticDocumentationArticle.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
use Hyde\Facades\Config;
88
use Hyde\Facades\Features;
99
use Hyde\Pages\DocumentationPage;
10+
use Illuminate\Support\Facades\View;
1011
use Illuminate\Support\HtmlString;
1112
use Illuminate\Support\Str;
1213

1314
use function explode;
1415
use function in_array;
1516
use function str_contains;
1617
use function trim;
17-
use function view;
1818

1919
/**
2020
* Class to make Hyde documentation pages smarter,
@@ -135,7 +135,7 @@ protected function addDynamicFooterContent(): static
135135

136136
protected function renderSourceLink(): string
137137
{
138-
return view('hyde::components.docs.edit-source-button', [
138+
return View::make('hyde::components.docs.edit-source-button', [
139139
'href' => $this->page->getOnlineSourcePath(),
140140
])->render();
141141
}

packages/framework/src/Framework/Views/Components/BreadcrumbsComponent.php

+4-5
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@
66

77
use Hyde\Hyde;
88
use Hyde\Foundation\Facades\Routes;
9-
use Illuminate\Contracts\View\Factory;
10-
use Illuminate\Contracts\View\View;
9+
use Illuminate\Support\Facades\View;
10+
use Illuminate\Contracts\View\View as ViewContract;
1111
use Illuminate\View\Component;
1212

1313
use function count;
1414
use function explode;
15-
use function view;
1615

1716
class BreadcrumbsComponent extends Component
1817
{
@@ -24,9 +23,9 @@ public function __construct()
2423
}
2524

2625
/** @interitDoc */
27-
public function render(): Factory|View
26+
public function render(): ViewContract
2827
{
29-
return view('hyde::components.breadcrumbs');
28+
return View::make('hyde::components.breadcrumbs');
3029
}
3130

3231
protected function makeBreadcrumbs(): array

packages/framework/src/Framework/Views/Components/LinkComponent.php

+4-6
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,10 @@
55
namespace Hyde\Framework\Views\Components;
66

77
use Hyde\Hyde;
8-
use Illuminate\Contracts\View\Factory;
9-
use Illuminate\Contracts\View\View;
8+
use Illuminate\Support\Facades\View;
9+
use Illuminate\Contracts\View\View as ViewContract;
1010
use Illuminate\View\Component;
1111

12-
use function view;
13-
1412
class LinkComponent extends Component
1513
{
1614
public readonly string $href;
@@ -21,8 +19,8 @@ public function __construct(string $href)
2119
}
2220

2321
/** @interitDoc */
24-
public function render(): Factory|View
22+
public function render(): ViewContract
2523
{
26-
return view('hyde::components.link');
24+
return View::make('hyde::components.link');
2725
}
2826
}

packages/framework/src/Markdown/Processing/CodeblockFilepathProcessor.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
use Hyde\Facades\Config;
88
use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
99
use Hyde\Markdown\Contracts\MarkdownPreProcessorContract;
10+
use Illuminate\Support\Facades\View;
1011
use Illuminate\Support\HtmlString;
1112

1213
use function preg_replace;
@@ -19,7 +20,6 @@
1920
use function implode;
2021
use function sprintf;
2122
use function trim;
22-
use function view;
2323

2424
/**
2525
* Resolves file path comments found in Markdown code blocks into a neat badge shown in the top right corner.
@@ -110,7 +110,7 @@ protected static function trimHydeDirective(string $line): string
110110

111111
protected static function resolveTemplate(string $path): string
112112
{
113-
return view('hyde::components.filepath-label', [
113+
return View::make('hyde::components.filepath-label', [
114114
'path' => Config::getBool('markdown.allow_html', false) ? new HtmlString($path) : $path,
115115
])->render();
116116
}

packages/framework/tests/Unit/BreadcrumbsComponentTest.php

+9-5
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
use Hyde\Support\Facades\Render;
1010
use Hyde\Support\Models\Route;
1111
use Hyde\Testing\UnitTestCase;
12-
use Illuminate\Contracts\View\Factory as ViewFactory;
1312
use Illuminate\Support\Facades\Facade;
13+
use Illuminate\Support\Facades\View;
1414
use Illuminate\View\Factory;
1515
use Mockery;
1616

@@ -44,11 +44,15 @@ public function testCanRender()
4444
{
4545
$this->mockPage(new MarkdownPage());
4646

47-
app()->instance(ViewFactory::class, Mockery::mock(Factory::class, function ($mock) {
48-
$mock->shouldReceive('make')->once()->andReturn($mock);
49-
}));
47+
$view = Mockery::mock(\Illuminate\View\View::class);
48+
$mock = Mockery::mock(Factory::class);
49+
$mock->shouldReceive('make')->once()->with('hyde::components.breadcrumbs')->andReturn($view);
50+
app()->singleton('view', fn () =>$mock);
51+
View::swap($mock);
5052

51-
$this->assertInstanceOf(Factory::class, (new BreadcrumbsComponent())->render());
53+
$this->assertSame($view, (new BreadcrumbsComponent())->render());
54+
55+
Mockery::close();
5256
}
5357

5458
public function testCanGenerateBreadcrumbs()

0 commit comments

Comments
 (0)