Merge pull request #1660 from hydephp/skip-sitemap-generations-when-setup-is-invalid

Skip sitemap generation when there is no valid base URL

Author: caendesilva

RELEASE_NOTES.md

@@ -18,6 +18,7 @@ This serves two purposes:
 
 ### Changed
 - The `features` array in the `config/hyde.php` configuration file is now an array of `Feature` enums in https://github.com/hydephp/develop/pull/1650
+- Sitemap generation will now be skipped if a base URL is not set, as Google now will not index sitemaps without a base URL in https://github.com/hydephp/develop/pull/1660
 
 ### Deprecated
 - Deprecated the static `Features` flag methods used in the configuration files in https://github.com/hydephp/develop/pull/1650 and will be removed in HydePHP v2.0

packages/framework/src/Framework/Actions/PostBuildTasks/GenerateSitemap.php

@@ -21,6 +21,10 @@ class GenerateSitemap extends PostBuildTask
 
     public function handle(): void
     {
+        if (blank(Hyde::url()) || str_starts_with(Hyde::url(), 'http://localhost')) {
+            $this->skip('Cannot generate sitemap without a valid base URL');
+        }
+
         $this->path = Hyde::sitePath('sitemap.xml');
 
         $this->needsParentDirectory($this->path);

packages/framework/tests/Feature/Services/BuildTaskServiceTest.php

@@ -30,6 +30,8 @@ class BuildTaskServiceTest extends TestCase
      */
     public function testBuildCommandCanRunBuildTasks()
     {
+        config(['hyde.url' => 'https://example.com']);
+
         $this->artisan('build')
             ->expectsOutputToContain('Removing all files from build directory')
             ->expectsOutputToContain('Generating sitemap')