Skip to content

Commit 9dacbc3

Browse files
authored
Merge pull request #496 from hydephp/refactor-hyde-pages
Move class ConstructsPageSchemas to internal namespace
2 parents d2630b9 + ebdfdea commit 9dacbc3

7 files changed

+8
-7
lines changed

packages/framework/src/Concerns/HydePage.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace Hyde\Framework\Concerns;
44

55
use Hyde\Framework\Actions\SourceFileParser;
6+
use Hyde\Framework\Concerns\Internal\ConstructsPageSchemas;
67
use Hyde\Framework\Contracts\CompilableContract;
78
use Hyde\Framework\Contracts\FrontMatter\PageSchema;
89
use Hyde\Framework\Contracts\RouteContract;
@@ -45,8 +46,8 @@ abstract class HydePage implements CompilableContract, PageSchema
4546
public Metadata $metadata;
4647

4748
public string $title;
48-
public ?array $navigation = null;
4949
public ?string $canonicalUrl = null;
50+
public ?array $navigation = null;
5051

5152
public function __construct(string $identifier = '', FrontMatter|array $matter = [])
5253
{

packages/framework/src/Concerns/ConstructsPageSchemas.php packages/framework/src/Concerns/Internal/ConstructsPageSchemas.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
namespace Hyde\Framework\Concerns;
3+
namespace Hyde\Framework\Concerns\Internal;
44

55
use Hyde\Framework\Actions\Constructors\FindsNavigationDataForPage;
66
use Hyde\Framework\Actions\Constructors\FindsTitleForPage;

packages/framework/tests/Feature/HydePageTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
* @covers \Hyde\Framework\Concerns\HydePage
2424
* @covers \Hyde\Framework\Concerns\BaseMarkdownPage
2525
* @covers \Hyde\Framework\Actions\Constructors\FindsNavigationDataForPage
26-
* @covers \Hyde\Framework\Concerns\ConstructsPageSchemas
26+
* @covers \Hyde\Framework\Concerns\Internal\ConstructsPageSchemas
2727
*/
2828
class HydePageTest extends TestCase
2929
{

packages/framework/tests/Feature/MarkdownPostTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
/**
1313
* @covers \Hyde\Framework\Models\Pages\MarkdownPost
14-
* @covers \Hyde\Framework\Concerns\ConstructsPageSchemas
14+
* @covers \Hyde\Framework\Concerns\Internal\ConstructsPageSchemas
1515
*/
1616
class MarkdownPostTest extends TestCase
1717
{

packages/framework/tests/Feature/PageModelConstructorsTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* Test the constructor actions and schema constructors for page models.
1212
*
1313
* @covers \Hyde\Framework\Actions\Constructors\FindsTitleForPage
14-
* @covers \Hyde\Framework\Concerns\ConstructsPageSchemas
14+
* @covers \Hyde\Framework\Concerns\Internal\ConstructsPageSchemas
1515
*/
1616
class PageModelConstructorsTest extends TestCase
1717
{

packages/framework/tests/Feature/Services/DocumentationSidebarTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
/**
1515
* @covers \Hyde\Framework\Models\Navigation\DocumentationSidebar
16-
* @covers \Hyde\Framework\Concerns\ConstructsPageSchemas
16+
* @covers \Hyde\Framework\Concerns\Internal\ConstructsPageSchemas
1717
*/
1818
class DocumentationSidebarTest extends TestCase
1919
{

packages/framework/tests/Unit/DocumentationPageTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
/**
1414
* @covers \Hyde\Framework\Models\Pages\DocumentationPage
15-
* @covers \Hyde\Framework\Concerns\ConstructsPageSchemas
15+
* @covers \Hyde\Framework\Concerns\Internal\ConstructsPageSchemas
1616
*/
1717
class DocumentationPageTest extends TestCase
1818
{

0 commit comments

Comments
 (0)