Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 404 button not leading to home on nested pages #37

Closed
caendesilva opened this issue Mar 28, 2022 · 0 comments · Fixed by #41
Closed

Bug: 404 button not leading to home on nested pages #37

caendesilva opened this issue Mar 28, 2022 · 0 comments · Fixed by #41
Assignees

Comments

@caendesilva
Copy link
Member

Currently the 404 page has a bug where it does not work on nested pages, due to the fact that the go home button links to the index.html page. This bug can be seen on the live site https://hydephp.github.io/docs/foo/bar.html, and since we can't calculate relative URLs like this we have a few options. We could make the button go back to the previous page or some kind of trickery.

But what I think I will do, unless anyone has any suggestions for how to do it better, is to make the link route to the app url if it is set, otherwise directly to the root path (href="/")

@caendesilva caendesilva self-assigned this Mar 30, 2022
@caendesilva caendesilva linked a pull request Mar 30, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant