Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Improvement: See if the Blade view directory can easily be changed #65

Closed
caendesilva opened this issue Apr 6, 2022 · 5 comments · Fixed by #90
Closed

UX Improvement: See if the Blade view directory can easily be changed #65

caendesilva opened this issue Apr 6, 2022 · 5 comments · Fixed by #90

Comments

@caendesilva
Copy link
Member

Laravel supports changing the source directories for Blade views. If Zero supports this properly and the publishable Hyde components also integrate it would make more sense to keep custom blade pages in a _views directory or similar.

@caendesilva
Copy link
Member Author

Actually not sure if this makes much more sense as we still probably would want to load Hyde components from the current place. Closing for now.

@caendesilva
Copy link
Member Author

caendesilva commented Apr 8, 2022

Reopening as I think we could actually load the Blade pages from the _pages directory. Thus bridging the gap between Markdown and Blade pages.

Edit: Yeah, this is what I'm looking for

@caendesilva caendesilva reopened this Apr 8, 2022
@caendesilva
Copy link
Member Author

Since there are a few breaking changes that are going to happen here I will log them all here as they are made so I don't miss any later on when writing the changelog and upgrade guide.

The config/view.php is updated to include the new source directory. Run php hyde publish:configs --force to update.

@caendesilva
Copy link
Member Author

This was actually much easier than I thought it would be. All tests are passing, docs just need to be updated. Drafting the PRs now.

@caendesilva caendesilva linked a pull request Apr 9, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant