Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing, suspected cause being mismatching line ending sequences #85

Closed
caendesilva opened this issue Apr 9, 2022 · 1 comment · Fixed by #86
Closed

Tests failing, suspected cause being mismatching line ending sequences #85

caendesilva opened this issue Apr 9, 2022 · 1 comment · Fixed by #86

Comments

@caendesilva
Copy link
Member

Discovered in hydephp/hyde#72 where checksum comparisons are not working as expected and thus causing test failures.

I suspect this is due to the hashing algorithm used includes the line ending sequences and since I ran the file cacher on a Windows machine some files use CRLF and since the test runner uses Ubuntu, and thus LF endings the files are different.

Going to try to create a crossplatform wrapper in the service class.

@caendesilva
Copy link
Member Author

caendesilva commented Apr 9, 2022

Cause confirmed to be EOL types. Working on a fix.

For reference:

"resources\/views\/layouts\/app.blade.php": {
      "md5sum": "10d70a2dc94fc1d751527da164e7b4dd",
      "unixsum": "10d70a2dc94fc1d751527da164e7b4dd",
      "last_modified": 1649502327
  },
  "resources\/views\/layouts\/docs.blade.php": {
      "md5sum": "11b037aa4ee4939d94062a6ef17fa7b2",
      "unixsum": "980ce346dd24e5424a7af23a920bab29",
      "last_modified": 1649480222
  },
  "resources\/views\/layouts\/footer.blade.php": {
      "md5sum": "6d6038140fc7e7dcf19fc901f7313487",
      "unixsum": "6f7626940d72d4605e8e518572dff46c",
      "last_modified": 1648153885
  },
  "resources\/views\/layouts\/meta.blade.php": {
      "md5sum": "cb6118a0e30b152564fb29d449de5973",
      "unixsum": "cb26d69c014458c79a78336fe54ff885",
      "last_modified": 1648153885
  },
  "resources\/views\/layouts\/navigation.blade.php": {
      "md5sum": "12214f98a83ace117cde1c1b5b17572a",
      "unixsum": "201491144f2918e054cabbe3c19e091a",
      "last_modified": 1648894753
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant