Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anna): Adding configurable seed nodes. #1288

Merged

Conversation

rohitkulshreshtha
Copy link
Contributor

  • Added support for hierarchical configuration using config crate & used it to set seed node information
  • Some cleanup for types & interfaces

@rohitkulshreshtha rohitkulshreshtha force-pushed the 1287-add-support-for-seed-nodes-for-gossip branch from 06aad3c to e169a3a Compare June 11, 2024 19:06
Copy link

cloudflare-workers-and-pages bot commented Jun 11, 2024

Deploying hydroflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6e60142
Status: ✅  Deploy successful!
Preview URL: https://0ea4d4bf.hydroflow.pages.dev
Branch Preview URL: https://1287-add-support-for-seed-no.hydroflow.pages.dev

View logs

Copy link
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one TODO in the doc comment

@rohitkulshreshtha rohitkulshreshtha force-pushed the 1287-add-support-for-seed-nodes-for-gossip branch from e169a3a to 6e60142 Compare June 11, 2024 21:27
@rohitkulshreshtha rohitkulshreshtha merged commit 9394512 into anna_v2 Jun 11, 2024
13 checks passed
rohitkulshreshtha added a commit that referenced this pull request Jun 20, 2024
* Added support for hierarchical configuration using `config` crate &
used it to set seed node information
* Some cleanup for types & interfaces
rohitkulshreshtha added a commit that referenced this pull request Jun 20, 2024
* Added support for hierarchical configuration using `config` crate &
used it to set seed node information
* Some cleanup for types & interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants