Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test latest stable (instead of nightly), fix #1587 #1607

Merged
merged 2 commits into from
Dec 12, 2024
Merged

ci: test latest stable (instead of nightly), fix #1587 #1607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad0a402
ci: test latest stable (instead of nightly), fix ##1587
MingweiSamuel Dec 12, 2024
bde3714
fixup! ci: test latest stable (instead of nightly), fix ##1587
MingweiSamuel Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 22 additions & 23 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
rust_release: [pinned-nightly, latest-nightly]
rust_release: [pinned-nightly, latest-stable]
exclude:
# For non-pull requests, event_name != 'pull_request' will be true, and 'nothing' is
# truthy, so the entire && operator will resolve to 'nothing'. Then the || operator will
# resolve to 'nothing' so we will exclude 'nothing'. https://stackoverflow.com/a/73822998
- rust_release: ${{ (needs.pre_job.outputs.should_skip != 'true' && 'nothing') || 'pinned-nightly' }}
- rust_release: ${{ (github.event_name != 'pull_request' && 'nothing') || 'latest-nightly' }}
- rust_release: ${{ (github.event_name != 'pull_request' && 'nothing') || 'latest-stable' }}

env:
CARGO_TERM_COLOR: always
Expand All @@ -55,12 +55,12 @@ jobs:
- name: Checkout sources
uses: actions/checkout@v3

- name: Install nightly toolchain
- name: Install toolchain
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: nightly
override: ${{ matrix.rust_release == 'latest-nightly' }}
toolchain: stable
override: ${{ matrix.rust_release == 'latest-stable' }}
components: rustfmt, clippy

- name: Run sccache-cache
Expand Down Expand Up @@ -96,25 +96,25 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
rust_release: [pinned-nightly, latest-nightly]
rust_release: [pinned-nightly, latest-stable]
exclude:
# For non-pull requests, event_name != 'pull_request' will be true, and 'nothing' is
# truthy, so the entire && operator will resolve to 'nothing'. Then the || operator will
# resolve to 'nothing' so we will exclude 'nothing'. https://stackoverflow.com/a/73822998
- rust_release: ${{ (needs.pre_job.outputs.should_skip != 'true' && 'nothing') || 'pinned-nightly' }}
- rust_release: ${{ (github.event_name != 'pull_request' && 'nothing') || 'latest-nightly' }}
- rust_release: ${{ (github.event_name != 'pull_request' && 'nothing') || 'latest-stable' }}

steps:
- name: Checkout sources
uses: actions/checkout@v3

- name: Install nightly toolchain
- name: Install toolchain
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: nightly
toolchain: stable
target: wasm32-unknown-unknown
override: ${{ matrix.rust_release == 'latest-nightly' }}
override: ${{ matrix.rust_release == 'latest-stable' }}

- name: Check hydroflow_lang
uses: actions-rs/cargo@v1
Expand All @@ -132,13 +132,13 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
rust_release: [pinned-nightly, latest-nightly]
rust_release: [pinned-nightly, latest-stable]
exclude:
# For non-pull requests, event_name != 'pull_request' will be true, and 'nothing' is
# truthy, so the entire && operator will resolve to 'nothing'. Then the || operator will
# resolve to 'nothing' so we will exclude 'nothing'. https://stackoverflow.com/a/73822998
- rust_release: ${{ (needs.pre_job.outputs.should_skip != 'true' && 'nothing') || 'pinned-nightly' }}
- rust_release: ${{ (github.event_name != 'pull_request' && 'nothing') || 'latest-nightly' }}
- rust_release: ${{ (github.event_name != 'pull_request' && 'nothing') || 'latest-stable' }}
- os: ${{ (github.event_name != 'pull_request' && 'nothing') || 'windows-latest' }}

env:
Expand All @@ -152,12 +152,12 @@ jobs:
- name: Checkout sources
uses: actions/checkout@v3

- name: Install nightly toolchain
- name: Install toolchain
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: nightly
override: ${{ matrix.rust_release == 'latest-nightly' }}
toolchain: stable
override: ${{ matrix.rust_release == 'latest-stable' }}

- name: Run sccache-cache
if: matrix.rust_release == 'pinned-nightly'
Expand Down Expand Up @@ -217,7 +217,7 @@ jobs:
cd python_tests
pip install -r requirements.txt
RUST_BACKTRACE=1 pytest

- name: Run Python tests (Windows)
if: ${{ matrix.os == 'windows-latest' }}
run: |
Expand All @@ -235,25 +235,25 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
rust_release: [pinned-nightly, latest-nightly]
rust_release: [pinned-nightly, latest-stable]
exclude:
# For non-pull requests, event_name != 'pull_request' will be true, and 'nothing' is
# truthy, so the entire && operator will resolve to 'nothing'. Then the || operator will
# resolve to 'nothing' so we will exclude 'nothing'. https://stackoverflow.com/a/73822998
- rust_release: ${{ (needs.pre_job.outputs.should_skip != 'true' && 'nothing') || 'pinned-nightly' }}
- rust_release: ${{ (github.event_name != 'pull_request' && 'nothing') || 'latest-nightly' }}
- rust_release: ${{ (github.event_name != 'pull_request' && 'nothing') || 'latest-stable' }}

steps:
- name: Checkout sources
uses: actions/checkout@v3

- name: Install nightly toolchain
- name: Install toolchain
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: nightly
toolchain: stable
target: wasm32-unknown-unknown
override: ${{ matrix.rust_release == 'latest-nightly' }}
override: ${{ matrix.rust_release == 'latest-stable' }}

- name: Get wasm-bindgen version
id: wasm-bindgen-version
Expand Down Expand Up @@ -366,11 +366,10 @@ jobs:
- name: Checkout sources
uses: actions/checkout@v3

- name: Install nightly toolchain
- name: Install toolchain
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: nightly

- name: Checkout gh-pages
shell: bash
Expand Down
Loading