Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice messages not shown #48

Open
ichthyosaurus opened this issue Oct 15, 2024 · 6 comments · May be fixed by element-hq/hydrogen-web#1195
Open

Voice messages not shown #48

ichthyosaurus opened this issue Oct 15, 2024 · 6 comments · May be fixed by element-hq/hydrogen-web#1195

Comments

@ichthyosaurus
Copy link
Collaborator

When I receive voice messages / audio attachments, they are not visible in the channel at all. (They do work in Sailtrix...)

I don't really know where to start debugging this.

@b100dian
Copy link
Contributor

I think the first test would be to try logging into hydrogen.element.io and see if they show up there. I did not use audio attachments so maybe it is easier for your.

If you make the window more portrait-ish you should get the mobile interface if I remember correctly.

Now, if you see the audio messages there, it means that the next thing we have to do is to upgrade our https://github.com/hydrogen-sailfishos/hydrogen-web fork to the current version - requires some small build changes and a link click bug fix and I should be able to to that when I have the time

@ichthyosaurus
Copy link
Collaborator Author

ichthyosaurus commented Oct 17, 2024

I think the first test would be to try logging into hydrogen.element.io and see if they show up there. I did not use audio attachments so maybe it is easier for your.

It doesn't show up there either, at all :/ So that means upstream doesn't support this, right? I'll open a bug report there.

Edit: I opened element-hq/hydrogen-web#1187

@ichthyosaurus
Copy link
Collaborator Author

@b100dian
Copy link
Contributor

I think seeing there is any audio message and then being able to download it is inifinitely better than nothing.

I would encourage you to make a pull request to hydrogen web, they might take a while to look at it but I got a small one in so it is open to contributions.

@b100dian
Copy link
Contributor

Ah, we could package the changes from your fork, but needs some setup. I just skiped our custom build because I could use hydrogen-web from upstream directly since 5.1, there's a PR for that. I'll consider this, thanks!

@ichthyosaurus
Copy link
Collaborator Author

I opened a PR upstream (element-hq/hydrogen-web#1195) but it may make sense to package my fixes manually because upstream appears to move quite slowly.

@ichthyosaurus ichthyosaurus mentioned this issue Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants