Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript error for interface ID #731

Closed
alpha0010 opened this issue Sep 25, 2019 · 1 comment · Fixed by #737
Closed

Typescript error for interface ID #731

alpha0010 opened this issue Sep 25, 2019 · 1 comment · Fixed by #737
Labels
❄️ types Typing issues

Comments

@alpha0010
Copy link
Contributor

Version of react-native-iap

3.4.13

Version of react-native

0.61.1

Steps to reproduce the behavior

$ npx tsc
node_modules/react-native-iap/index.d.ts:5:22 - error TS2693: 'string' only refers to a type, but is being used as a value here.

5 interface ID extends string {}
                       ~~~~~~
@hyochan
Copy link
Owner

hyochan commented Sep 26, 2019

@alpha0010 Could you kindly give a PR on this?

@hyochan hyochan added the ❄️ types Typing issues label Sep 26, 2019
@maxencehenneron maxencehenneron mentioned this issue Sep 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
❄️ types Typing issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: interface "ID" extending a primitive type
2 participants
@alpha0010 @hyochan