-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments in the imported file via "require" should be removed. #21
Comments
You can require minified version: |
suddenly no! :) I don't know why, but
Similar problem might be actual for other modules used by "require" Also another point why comments need to be removed, I can prepare some lib for myself with items that I will need:, e.g export let $my_ramda = {
invertObj: require( 'ramda/src/invertObj.js' ) as typeof import( 'ramda' ).invertObj,
uniq: require( 'ramda/src/uniq.js' ) as typeof import( 'ramda' ).uniq,
concat: require( 'ramda/src/concat.js' ) as typeof import( 'ramda' ).concat,
mergeWith: require( 'ramda/src/mergeWith.js' ) as typeof import( 'ramda' ).mergeWith,
keys: require( 'ramda/src/keys.js' ) as typeof import( 'ramda' ).keys
} and builder removes comments from mol's sources, but not from required files, there are no sense in vendor's lib's comments. |
Comments from TS sources are removed by typescript. In the future we should use some bundler to import NPM modules. Current implementation is very limited. |
agree, maybe no need to focus on it too much now. |
Currently If you use "require" to import npm's lib (like in lib/ramda -
$lib_ramda = require('ramda/src/index.js') as typeof import('ramda')
) than comments will be not removed.Example of generated web.js source
The text was updated successfully, but these errors were encountered: