Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable restrictiveness for various header checks #619

Open
rahulanand16nov opened this issue May 31, 2022 · 0 comments
Open

Comments

@rahulanand16nov
Copy link

rahulanand16nov commented May 31, 2022

We are using h2 in one of our rust services that are deployed on K8s and used in mesh with Istio. Since at the data-plane level Envoy is used, Envoy has an old behavior of passing authority header in the format of outbound|port||service-name to the service being called.

When a request from Envoy reaches our Rust service, it rejects the request due to a malformed authority header:
malformed headers: malformed authority (b"outbound|8081||limitador.rahul-test.svc.cluster.local"): invalid uri character. It makes sense since | is not part of the RFC for authority header but I feel this check should be configurable depending on feature flags or something similar.

Most libraries in other languages are pretty relaxed about these checks and thus work flawlessly so I feel it's one of the areas we can improve upon in h2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant